Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add watchers to imports within vue files #385

Merged
merged 2 commits into from Oct 22, 2020
Merged

add watchers to imports within vue files #385

merged 2 commits into from Oct 22, 2020

Conversation

@neryams
Copy link
Contributor

@neryams neryams commented Aug 31, 2020

the watcher should rebuild vue files when the file's imports are updated. Without this, the rollup build doesn't rebuild when you update .ts and .scss/sass files that are in your build

Changes proposed in this pull request:

  • Add vue SFC imported files to the rollup watcher

/ping @znck

the watcher should rebuild vue files when the file's imports are updated
@neryams
Copy link
Contributor Author

@neryams neryams commented Sep 22, 2020

@znck Any thoughts on this? It's troublesome to have to keep restarting my build. That circleci error I can't do anything about, the base repository doesn't seem to have a config file.

@znck znck dismissed their stale review Oct 20, 2020

Need a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants