Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-next] Fix Rollup when no template in an SFC #387

Merged
merged 6 commits into from Oct 20, 2020

Conversation

@elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Sep 9, 2020

Changes proposed in this pull request:
SFCs can have a script block only
In this case, the render function should not be replaced by the empty template function.
It should be left alone.

/ping @znck @jtommy

@jtommy
Copy link

@jtommy jtommy commented Sep 9, 2020

@elevatebart Yes, removing it seems to work as I tried manually but I don't know if it's really correct or not in the new Vue 3 (maybe we are missing something..)

isServer
)

const templateImport = descriptor.template

This comment has been minimized.

@jtommy

jtommy Sep 16, 2020

The right condition is !descriptor.template

@@ -0,0 +1,10 @@
<script>
import h from 'vue'

This comment has been minimized.

@jtommy

jtommy Sep 16, 2020

h isnt' the default export, you should use import { h } from 'vue'

@znck
znck approved these changes Oct 20, 2020
@znck znck merged commit 6960203 into vuejs:next Oct 20, 2020
1 check failed
1 check failed
ci/circleci: Build Error Your tests failed on CircleCI
Details
@meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Oct 22, 2020

Some edge cases that may be related to vuejs/vue-next#2463

@zouhangwithsweet
Copy link

@zouhangwithsweet zouhangwithsweet commented Oct 29, 2020

I am troubled by this question.
When will you release the new version, maybe beta.11 ?👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants