Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): do not overwrite globalProperties merge them instead #1788

Merged
merged 1 commit into from Oct 2, 2022

Conversation

xanf
Copy link
Collaborator

@xanf xanf commented Oct 2, 2022

  • globalProperties might not be empty due to them being gathered from Vue.prototype when using compat build

By overwriting this properties any "legacy" plugin configuration, which adds properties via Vue.prototype will loose them, cause we will overwrite globalProperties with default empty object

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit d4ef628
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/6339d77523fd170008f1798e
😎 Deploy Preview https://deploy-preview-1788--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

* globalProperties might not be empty due to them being gathered
from Vue.prototype when using compat build
@xanf xanf force-pushed the xanf-fix-vue-compat-globalProperties branch from 4dd72e4 to d4ef628 Compare October 2, 2022 18:24
@cexbrayat cexbrayat merged commit e754fd1 into main Oct 2, 2022
7 checks passed
@cexbrayat cexbrayat deleted the xanf-fix-vue-compat-globalProperties branch October 2, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants