Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mount): simplify mount operation #1844

Merged
merged 1 commit into from Nov 3, 2022
Merged

Conversation

xanf
Copy link
Collaborator

@xanf xanf commented Nov 3, 2022

Found this approach in main @vuejs/core repo

https://github.com/vuejs/core/blob/main/packages/runtime-core/__tests__/rendererTemplateRef.spec.ts#L23

I think this might be a good approach to simplify our codebase too!

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 9d594e3
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/63636428587e050008e83c9f
😎 Deploy Preview https://deploy-preview-1844--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an unused import to remove to make CI happy

* do not use ugly console.warn hack
@xanf
Copy link
Collaborator Author

xanf commented Nov 3, 2022

@cexbrayat that was fast, I've even was unable to push another version (full one), since my internet connection got flaky (I'm commuting between two cities via train 🚋 )

Now this one is a final state :)

@xanf xanf merged commit cebc0e0 into main Nov 3, 2022
8 checks passed
@xanf xanf deleted the xanf-simplify-ref-access branch November 3, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants