setProps #51
Merged
setProps #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| props[k] = v | ||
| } | ||
|
|
||
| return app.$nextTick() |
yyx990803
reviewed
Apr 10, 2020
src/mount.ts
Outdated
| const app = vm.mount(el) | ||
|
|
||
| return createWrapper(app, events) | ||
| return { |
Member
There was a problem hiding this comment.
Why not
const wrapper = createWrapper(app, events)
wrapper.setProps = setProps
return wrapper
Member
Author
There was a problem hiding this comment.
it works
I was too far down the rabbit hole to see the top 😆
afontcu
approved these changes
Apr 11, 2020
dobromir-hristov
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers all test cases from beta, and a number of bugs, (eg
setPropsandwatchwas buggy; now it is not).