From 63583402500acd8e22e24d0dcefd4aa684156d24 Mon Sep 17 00:00:00 2001 From: yoyo930021 Date: Fri, 16 Oct 2020 18:30:05 +0800 Subject: [PATCH] Update RFC --- rfcs/002-monorepo-support.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/rfcs/002-monorepo-support.md b/rfcs/002-monorepo-support.md index 63397c07bc..91c36a75db 100644 --- a/rfcs/002-monorepo-support.md +++ b/rfcs/002-monorepo-support.md @@ -56,10 +56,10 @@ One project scope per VLS dedicated service. The TypeScript is support multile project in one server. It will make one Project to one TLS. It is based on `tsconfig.json` location. -Because only TS feature needs this feature at the moment, +Because only TypeScript/JavaScript feature needs this feature at the moment, Example: https://github.com/angular/vscode-ng-language-service -PS. Slightly different is that the project relies entirely on TS plugins. +PS. In this example from angular, Slightly different is that the project relies entirely on TS plugins. Similar PR: https://github.com/vuejs/vetur/pull/1734 #### Benefits @@ -71,7 +71,7 @@ Similar PR: https://github.com/vuejs/vetur/pull/1734 - It may create something completely unnecessary TLS when having project no Vue, maybe need a lazy logic? - In the vue ecosystem, it isn't support multiple `tsconfig.json`, It's a little redundant. [more info](https://github.com/vuejs/vetur/blob/vetur-config-file-rfc/rfcs/001-vetur-config-file.md#why-isnt-array) - Performance is affected by the interplay between projects. unless the separation process is implemented with node `worker_threads`. -- The template interpolation need to refactor and design. +- ~~The template interpolation need to refactor and design~~, At least it's not a problem now. But I'm not sure if we'll break anything if we let Template interpolation have multiple files importing from each other. - Because there is no defined project in VLS, register globally components could be inaccurate. @@ -99,3 +99,4 @@ Not yet decided - Have any multiple `tsconfig.json` case for a Vue project? - What to base a project on? Use `tsconfig.json`, `package.json`, or config in [RFC](https://github.com/vuejs/vetur/pull/2378)? - Which plan to use? +- Have any multiple `tsconfig.json` case for a other framework project? React? Angular?