Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Apply template interpolation validation only to TypeScript components #1439
The PR checks if the current document includes
What I still need assistance with:
Please absolute suggest any changes or alternative approaches; just wanted to get an initial approach out there. There are currently 2 failing
Allow all other interpolation services to continue to run, even when the component does not have TypeScript enabled
(should not be merged until we at least address the failing specs, and hopefully the
The known failing specs:
1) Shows template diagnostics for jsdocs-type-check.vue 2) Shows template diagnostics for external-script.vue
(also, as an aside - major hats off for the extremely thorough test suite, auto-linting, tests-on-push, thorough typing everywhere, and CI setup. A joy of a codebase to contribute to)
Thank you for the PR! I'll look into the details when I have more extra time.
Looks like we can get this info from
We still need to think about how we get source file object in
Looks good to me.