From 6c899437c15b126b488e73c99cdaad77fc7e5611 Mon Sep 17 00:00:00 2001
From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Date: Sun, 31 Dec 2023 12:46:16 +0530
Subject: [PATCH] feat(theme): allow specifying rel and target in logoLink

closes #3264
closes #3271
---
 .../components/VPNavBarTitle.vue              | 26 ++++++++++++++++++-
 types/default-theme.d.ts                      |  4 +--
 2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/src/client/theme-default/components/VPNavBarTitle.vue b/src/client/theme-default/components/VPNavBarTitle.vue
index 51f4233c9c56..eadef0864ae6 100644
--- a/src/client/theme-default/components/VPNavBarTitle.vue
+++ b/src/client/theme-default/components/VPNavBarTitle.vue
@@ -1,4 +1,5 @@
 <script setup lang="ts">
+import { computed } from 'vue'
 import { useData } from '../composables/data'
 import { useLangs } from '../composables/langs'
 import { useSidebar } from '../composables/sidebar'
@@ -8,11 +9,34 @@ import VPImage from './VPImage.vue'
 const { site, theme } = useData()
 const { hasSidebar } = useSidebar()
 const { currentLang } = useLangs()
+
+const link = computed(() =>
+  typeof theme.value.logoLink === 'string'
+    ? theme.value.logoLink
+    : theme.value.logoLink?.link
+)
+
+const rel = computed(() =>
+  typeof theme.value.logoLink === 'string'
+    ? undefined
+    : theme.value.logoLink?.rel
+)
+
+const target = computed(() =>
+  typeof theme.value.logoLink === 'string'
+    ? undefined
+    : theme.value.logoLink?.target
+)
 </script>
 
 <template>
   <div class="VPNavBarTitle" :class="{ 'has-sidebar': hasSidebar }">
-    <a class="title" :href="theme.logoLink ?? normalizeLink(currentLang.link)">
+    <a
+      class="title"
+      :href="link ?? normalizeLink(currentLang.link)"
+      :rel="rel"
+      :target="target"
+    >
       <slot name="nav-bar-title-before" />
       <VPImage v-if="theme.logo" class="logo" :image="theme.logo" />
       <template v-if="theme.siteTitle">{{ theme.siteTitle }}</template>
diff --git a/types/default-theme.d.ts b/types/default-theme.d.ts
index be5cd0d3a855..fc8d4343150e 100644
--- a/types/default-theme.d.ts
+++ b/types/default-theme.d.ts
@@ -20,7 +20,7 @@ export namespace DefaultTheme {
     /**
      * Overrides the link of the site logo.
      */
-    logoLink?: string
+    logoLink?: string | { link?: string; rel?: string; target?: string }
 
     /**
      * Custom site title in navbar. If the value is undefined,
@@ -174,8 +174,8 @@ export namespace DefaultTheme {
      * RegExp object here because it isn't serializable
      */
     activeMatch?: string
-    target?: string
     rel?: string
+    target?: string
   }
 
   export interface NavItemChildren {