Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The actionLink missing $withBase #168

Closed
tolking opened this issue Dec 1, 2020 · 1 comment · Fixed by #169
Closed

The actionLink missing $withBase #168

tolking opened this issue Dec 1, 2020 · 1 comment · Fixed by #169
Labels
bug Something isn't working
Projects
v1.0.0-alpha

Comments

@tolking
Copy link
Contributor

tolking commented Dec 1, 2020

Describe the bug
The actionLink in HomeHero.vue missing $withBase,

Expected behavior
It should configure the base path like other links

System Info

  • vitepress version: 0.9.0
@tolking tolking added the bug: pending triage Maybe a bug, waiting for confirmation label Dec 1, 2020
@kiaking
Copy link
Member

kiaking commented Dec 1, 2020

Good catch! Thanks. We should add it.

@kiaking kiaking added bug Something isn't working and removed bug: pending triage Maybe a bug, waiting for confirmation labels Dec 1, 2020
@kiaking kiaking added this to To do in v1.0.0-alpha Dec 1, 2020
@tolking tolking mentioned this issue Dec 1, 2020
Merged
v1.0.0-alpha automation moved this from To do to Done Dec 5, 2020
yyx990803 pushed a commit that referenced this issue Dec 5, 2020
@tolking
fix(theme): the actionLink miss withBase (#168) (#169)
ffaca73
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v1.0.0-alpha
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): the actionLink miss withBase (#168) tolking/vitepress
2 participants
@kiaking @tolking