Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): refine overall styles #1790

Merged
merged 3 commits into from
Jan 17, 2023
Merged

feat(theme): refine overall styles #1790

merged 3 commits into from
Jan 17, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jan 13, 2023

close #1049

Organize and refine entire styles toward a stable release. I'm hoping this would be the last big breaking change on CSS variables.

I've tested with Vite site and it worked without modifying Vite's themes, so I think this is fairly safe, but users who do heavy customization might encounter coloring issues.

CSS Variable adjustment

I wanted to pay extra attention to reducing CSS variables so that it's easier for users to tweak the stylings.

I've almost entirely eliminated the need for .dark scoping. 99% (maybe 90%...) of stuff should work only by adjusting branding colors and no .dark override should be needed.

Adjusted the tone

I needed to adjust the tone of the design a bit to make single color work on both light and dark modes. I went to several docs sites like Laravel and others and adjusted the overall theme to be a bit darker, cooler (add a little bit of blue), and slightly higher contrast.

Nav adjustment

  • Restructured VPNav so that it fills the entire page width for easier Nav styling.
  • Removed blued background effect, and instead added fader same as we have at bottom of the aside section for docs.
    • With this change, now Home Hero background gradient will not be cut off via nav.
  • Set same height on both mobile and desktop for simplicity.

@brc-dd Could you go through several random pages to see if I didn't break anything? I've tested with Vite sites, and everything seems to be working including sponsors and team sections.


Screen Shot 2023-01-13 at 17 01 35

Screen Shot 2023-01-13 at 17 02 06

@kiaking kiaking added enhancement New feature or request theme Related to the theme labels Jan 13, 2023
@kiaking kiaking added this to the v1.0.0 milestone Jan 13, 2023
@kiaking kiaking requested a review from brc-dd January 13, 2023 08:37
@kiaking kiaking self-assigned this Jan 13, 2023
@brc-dd
Copy link
Member

brc-dd commented Jan 13, 2023

Looks great to me!

@brc-dd
Copy link
Member

brc-dd commented Jan 14, 2023

Hey, might wanna update this component too: https://github.com/vuejs/vitepress/blob/main/docs/components/ModalDemo.vue

@kiaking kiaking merged commit 471f00a into main Jan 17, 2023
@kiaking kiaking deleted the styles-organization branch January 17, 2023 13:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur backdrop filter on navbar noticeably impacts scroll performance
2 participants