Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(build): remove leading underscore from chunks" #1471

Merged
merged 1 commit into from Oct 12, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 12, 2022

Reverts #1394

@brc-dd brc-dd merged commit 18f0fb4 into main Oct 12, 2022
8 checks passed
@brc-dd brc-dd deleted the revert-1394-fix/sanitize-filename branch Oct 12, 2022
@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 13, 2022

Hi, could you make a little explanation why this is reverted? Are there some issues caused by this?

@brc-dd
Copy link
Member Author

brc-dd commented Oct 13, 2022

It was breaking client builds if documents have leading underscore. I'm not sure if people have that, but it was sort of an edge case. The regex needs some modifications to remove leading _ from file name not the path. I'll try to add it in #1475 itself. For now consider adding a .nojekyll file in your public directory if the issue is with GH Pages.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants