Typo fix and code format #2419
Closed
Typo fix and code format #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodatea
requested changes
Dec 30, 2018
docs/dev-guide/ui-api.md
Outdated
| @@ -943,7 +952,7 @@ In the client addon components (browser), you have access to `$onPluginActionCal | |||
| ```js | |||
| // Vue component | |||
| export default { | |||
| created () { | |||
| created() { | |||
There was a problem hiding this comment.
The spaces before function parentheses are intentional.
See https://github.com/vuejs/eslint-plugin-vue-libs/blob/a3b63ec188d504e1421c9437833dd3f92fdb358a/config.js#L122
The rest of this PR is fine.
Thanks for the help!
There was a problem hiding this comment.
OK Sure i will update that... Thanks
Keeping spaces between function name and parantheses
sodatea
requested changes
Jan 2, 2019
| @@ -990,7 +999,7 @@ function sendMessage (data) { | |||
| }) | |||
| } | |||
|
|
|||
| function messageHandler (data) { | |||
| function messageHandler(data) { | |||
| @@ -1000,7 +1009,7 @@ ipc.on(messageHandler) | |||
| // Don't listen anymore | |||
| ipc.off(messageHandler) | |||
|
|
|||
| function cleanup () { | |||
| function cleanup() { | |||
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.