Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add --host option #2568

Merged
merged 2 commits into from Oct 20, 2018

Conversation

Projects
7 participants
@ykzts
Copy link
Contributor

ykzts commented Sep 21, 2018

$ vue ui --host 0.0.0.0
馃殌  Starting GUI...
馃尃  Ready on http://localhost:8000

Currently vue ui can not connect from outside. This is because it is bound to localhost.

In this Pull Request, an option is added so that it can be changed to host other than localhost.

@Akryum
Copy link
Member

Akryum left a comment

Thanks for the PR! Could you remove the unrelated dependency changes from it please? Thanks!

@ykzts

This comment has been minimized.

Copy link
Contributor Author

ykzts commented Sep 22, 2018

Thanks for the PR! Could you remove the unrelated dependency changes from it please? Thanks!

done!

@ykzts

This comment has been minimized.

Copy link
Contributor Author

ykzts commented Sep 24, 2018

rebased

@liugang

This comment has been minimized.

Copy link

liugang commented Sep 26, 2018

It's best to change -h to -H, because -h is use for -h, --help output usage information

option('-h, --host <host>', 'Host used for the UI server (default: localhost)')

@sodatea sodatea added this to the Next Minor milestone Sep 28, 2018

@jevillard

This comment has been minimized.

Copy link

jevillard commented Oct 6, 2018

Nice feature :)

@sodatea sodatea added this to To review in 3.1.0 Oct 20, 2018

@sodatea sodatea merged commit be814b3 into vuejs:dev Oct 20, 2018

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

3.1.0 automation moved this from To review to Done Oct 20, 2018

@ykzts ykzts deleted the ykzts:host branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.