Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dart-sass as default sass implementation #3321

Merged
merged 4 commits into from Jan 28, 2019
Merged

Conversation

@sodatea
Copy link
Member

sodatea commented Jan 17, 2019

closes #1782

  1. sass + fibers combined is ~10MiB smaller than the node-sass package, and approximately 1.5x slower in performance (perf report, and with fibers there's a 2x speedup)
  2. It's the future of sass

TODOs in this PR:

  1. Should add tests
  2. This PR uses a try ... catch block to test if sass package can be resolved and default to it. Should we make it more explicit? How?
@sodatea sodatea added this to In progress in January Update via automation Jan 20, 2019
@sodatea sodatea moved this from In progress to Needs review in January Update Jan 20, 2019
sodatea added 3 commits Jan 27, 2019
@sodatea sodatea merged commit 9c1e797 into vuejs:dev Jan 28, 2019
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
January Update automation moved this from Needs review to Done Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.