Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ui): improve get folder list to use Promises instead of sync #3687

Merged
merged 3 commits into from Sep 1, 2020

Conversation

@pikax
Copy link
Member

@pikax pikax commented Mar 20, 2019

Use Promises to get if the file isHidden and isDirectory, this improves the performance when doing project/select.

On windows was taking around 1~2seconds to fetch a directory (using SSD), with this I manage to get 300~600ms.

@pikax pikax changed the title perf(ui): improve get folder list to use only Promises perf(ui): improve get folder list to use Promises instead of sync Mar 21, 2019
@sodatea
sodatea approved these changes Sep 1, 2020
@sodatea sodatea merged commit 10d5ae4 into vuejs:dev Sep 1, 2020
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@pikax pikax deleted the pikax:improve-folders-perf branch Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants