Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check for `nightwatch.conf.js` config #4445

Merged

Conversation

@LukeeeeBennett
Copy link
Contributor

commented Aug 16, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature (Not really but most relevant)
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Nightwatch checks for nightwatch.conf.js instead
of the existing nightwatch.config.js user options
file, this adds a branch to check for the file
suggested by upstream as well.

Please see https://nightwatchjs.org/gettingstarted#configuration

There are currently no tests for this behaviour. Feel free to point me in the right direction.

feat: Check for `nightwatch.conf.js` config
Nightwatch checks for `nightwatch.conf.js` instead
of the existing `nightwatch.config.js` user options
file, this adds a branch to check for the file
suggested by upstream as well.
@LukeeeeBennett

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

mic tap

@sodatea
sodatea approved these changes Sep 3, 2019

@sodatea sodatea merged commit 8975d84 into vuejs:dev Sep 3, 2019

6 of 7 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

Hey @LukeeeeBennett, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.