Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @vue/unit-mocha install instructions #4536

Open
wants to merge 1 commit into
base: v3
from

Conversation

@devjack
Copy link

commented Sep 1, 2019

Similar to this comment addressing vue-jest install issues, the install instructions for @vue/unit-mocha have also changed and need to be updated too.

Before change:

Instructions currently read, and produce:

vue add unit-mocha

馃摝  Installing vue-cli-plugin-unit-mocha...

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/vue-cli-plugin-unit-mocha - Not found
npm ERR! 404 

After change

Instructions that current work, and should read/produce:

vue add @vue/unit-mocha

馃摝  Installing @vue/cli-plugin-unit-mocha...

+ @vue/cli-plugin-unit-mocha@3.11.0
added 70 packages from 505 contributors and audited 29226 packages in 17.477s

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Update @vue/unit-mocha install instructions
Similar to [this comment](#4294 (comment)) addressing vue-jest install issues, the install instructions for `@vue/unit-mocha` have also changed and need to be updated too.

#### Before change:

```bash
vue add unit-mocha

馃摝  Installing vue-cli-plugin-unit-mocha...

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/vue-cli-plugin-unit-mocha - Not found
npm ERR! 404 
```

#### After change

```bash
vue add @vue/unit-mocha

馃摝  Installing @vue/cli-plugin-unit-mocha...

+ @vue/cli-plugin-unit-mocha@3.11.0
added 70 packages from 505 contributors and audited 29226 packages in 17.477s
```
@NataliaTepluhina
Copy link
Contributor

left a comment

@devjack thank you for spotting this? Regarding the contributing guide could you please change the base branch to master?

@felixiho

This comment has been minimized.

Copy link

commented Sep 2, 2019

I also realised this also happens in the instructions for @vue/unit-jest installation instructions.
Tried to install via the current instructions which read vue add unit-jest and it threw the same error as above.

@sodatea
Copy link
Member

left a comment

We've allowed omitting the scope prefix for official plugins since v3.11.0.
I think adding a simple version notice would suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.