Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: [wip] make workbox-webpack-plugin a peer dependency #4565

Closed
wants to merge 2 commits into from

Conversation

@sodatea
Copy link
Member

commented Sep 11, 2019

Update: I'm very hesitant about this refactor. Will give it another look next week.

TODOs:

  • implement a migrator for vue upgrade to automate the migration
  • implement a postinstall script for prerelease users who don't use vue upgrade to upgrade this plugin. Adding a postinstall script does not make sense as we've got migrators already. I think adding a strong and explicit is enough.

Considering workbox team is preparing a v5 release.
It's likely that in the early-to-middle stage of Vue CLI v4 lifecycle that a major version bump of workbox may happen.
By making it a peer dep we could have more flexibility on version strategies.

We should do the similar to the unit-jest plugin.
IMO these are our last two remaining issues before an official v4 release.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

refactor!: make workbox-webpack-plugin a peer dependency
Considering workbox team is preparing a v5 release.
It's likely that in the early-to-middle stage of Vue CLI v4 lifecycle
that a major version bump of workbox may happen.
By making it a peer dep we could have more flexibility on version
strategies.

@sodatea sodatea changed the title refactor!: make workbox-webpack-plugin a peer dependency refactor!: [wip] make workbox-webpack-plugin a peer dependency Sep 14, 2019

@sodatea

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

Closing this because separating such an essential dependency out could be a much larger maintenance burden to us.

@sodatea sodatea closed this Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.