Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid accidentally overriding sass config with scss configs #4637

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@sodatea
Copy link
Member

commented Oct 1, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@sodatea sodatea added the PR: Bug Fix label Oct 1, 2019
@sodatea sodatea merged commit e63bf61 into vuejs:dev Oct 1, 2019
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the sodatea:fix-default-sass-override branch Oct 1, 2019
sodatea added a commit to sodatea/vue-cli that referenced this pull request Oct 9, 2019
…js#4637)

(cherry picked from commit e63bf61)
sodatea added a commit that referenced this pull request Oct 10, 2019
* feat: support sass-loader v8

(cherry picked from commit af17a9b)

* fix: fix sassOptions merging for scss syntax in sass-loader v8 (#4631)

fixes #4630

(cherry picked from commit ebdb142)

* fix: avoid accidentally overriding sass config with scss configs (#4637)

(cherry picked from commit e63bf61)

* chore: don't warn user for sass-loader version here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.