Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(router): added router array type for Array RouteConfig #4787

Closed
wants to merge 1 commit into from

Conversation

@manuelojeda
Copy link

manuelojeda commented Nov 2, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:
    Added a conditional in the generator of router when TypeScript is selected, added the routes array as <Array>, when using the @vue/composition-api using the routes without the type may return an error of incompatibility

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Copy link
Member

sodatea left a comment

Please don't commit package-lock.json.
Also, we do lockfile maintenance periodically, so please don't include yarn.lock changes in this PR.

@manuelojeda manuelojeda closed this Nov 7, 2019
@manuelojeda

This comment has been minimized.

Copy link
Author

manuelojeda commented Nov 7, 2019

I'm closing this PR to make a new one with the correct changes without adding the lock files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.