Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build error when path contains space (close #4667) #4809

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@RSeidelsohn
Copy link
Contributor

RSeidelsohn commented Nov 7, 2019

Fixes issue #4667 by implementing the proposal #4667 (comment) (I opened that issue and checked if this change really fixes the issue I had - it does)
Also gets rid of a node module by using simpler code for removing eventual GET parameters

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Fixes issue #4667 by implementing the proposal #4667 (comment)
Also gets rid of a node module by using simpler code for removing eventual GET parameters
Co-Authored-By: Haoqun Jiang <haoqunjiang@gmail.com>
@sodatea
sodatea approved these changes Nov 8, 2019
@sodatea sodatea merged commit 26c4899 into vuejs:dev Nov 8, 2019
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vue-bot

This comment has been minimized.

Copy link

vue-bot commented Nov 8, 2019

Hey @RSeidelsohn, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@sodatea sodatea changed the title fix(lib): replace "url" module with simple string split (close #4667) fix(build): fix build error when path contains space (close #4667) Nov 8, 2019
@sodatea sodatea changed the title fix(build): fix build error when path contains space (close #4667) fix: fix build error when path contains space (close #4667) Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.