Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect existing package.json #4827

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@zyy7259
Copy link
Contributor

zyy7259 commented Nov 11, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

This pull request will close #4544

@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch from 9fe2f01 to 6fb189a Nov 14, 2019
@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch 2 times, most recently from 9969dcc to 401c9f0 Nov 27, 2019
@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch 2 times, most recently from 6b6f6c3 to 57e753e Dec 5, 2019
Copy link
Collaborator

pksunkara left a comment

Commented above.

@zyy7259 zyy7259 mentioned this pull request Dec 13, 2019
2 of 9 tasks complete
@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch 5 times, most recently from 14ea723 to d8e51c5 Dec 18, 2019
@zyy7259

This comment has been minimized.

Copy link
Contributor Author

zyy7259 commented Dec 31, 2019

@pksunkara hi, I have modified the code as you requested. Should I rebase the code every time when dev has newer commits?

@pksunkara

This comment has been minimized.

Copy link
Collaborator

pksunkara commented Dec 31, 2019

Yes, please rebase since we need to re trigger CI

@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch from d8e51c5 to 3971dd5 Dec 31, 2019
@sodatea
sodatea approved these changes Jan 3, 2020
@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch 2 times, most recently from 93c6c02 to c47afb0 Jan 5, 2020
@zyy7259 zyy7259 force-pushed the zyy7259:respect-existing-package.json branch from c47afb0 to ddf478f Jan 6, 2020
@sodatea sodatea merged commit eaa2b73 into vuejs:dev Jan 9, 2020
6 of 7 checks passed
6 of 7 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.