Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix duplicate id="app" in Vue 3 project template #5852

Merged
merged 1 commit into from Sep 8, 2020

Conversation

@sodatea
Copy link
Member

@sodatea sodatea commented Sep 7, 2020

closes #5813

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

closes #5813
@sodatea sodatea merged commit 34c09dc into vuejs:dev Sep 8, 2020
7 checks passed
7 checks passed
ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sodatea sodatea deleted the sodatea:fix-vue3-root branch Sep 8, 2020
@9mm
Copy link

@9mm 9mm commented Sep 8, 2020

Just wondering, does this remove one of the #app divs from index.html or App.vue? Or, does it cause the App.vue node to replace the index.html node like in vue 2?

I tried to install vue-cli from master to check myself, but it complains about version mismatch.

@sodatea
Copy link
Member Author

@sodatea sodatea commented Sep 8, 2020

From App.vue, the one in the HTML still needs to exist to be served as a mounting point.

@HackyDev
Copy link

@HackyDev HackyDev commented Sep 11, 2020

The new version of App.vue has styles for the #app container declared in the index.html. It doesn't feel right, because the component applies styles to an element declared outside its template.

@titusdecali
Copy link

@titusdecali titusdecali commented Apr 18, 2021

I agree with @HackyDev, this is very strange and should be reduced to a single #app.
I've just created a new Vue3 app with the CLI on 4/18/2021 and this issues till persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants