Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari DevTools active on production site when disabled in main.js #632

Closed
bigsee opened this issue Feb 28, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@bigsee
Copy link

commented Feb 28, 2018

Version

4.1.3

Browser and OS info

Safari 11.0.2, Mac OS 10.13.2

Steps to reproduce

Specify in the main.js file that vue-devtools should be disabled in production mode:

if (process.env.NODE_ENV === 'production') {
  Vue.config.devtools = false;
}
  1. Open a URL in Chrome where there is a production build and confirm that dev tools have been disabled
  2. Open the same URL in Safari and click on the devtools button

What is expected?

  1. A message, similar to the one in Chrome, which states: "Vue.js is detected on this page. Devtools inspection is not available because it's in production mode or explicitly disabled by the author."
  2. No components or other data to be visible

What is actually happening?

The dev tools are still available and I can see all the components and state, even in production.

@bigsee bigsee changed the title Safari DevTools active on production site Safari DevTools active on production site when disabled in main.js Feb 28, 2018

@bigsee

This comment has been minimized.

Copy link
Author

commented Mar 1, 2018

@jaredhobbs kindly confirmed that this is a known bug here: #352

When a user visits a site in development mode then then later visits the production version in the same browser session, the devtools will appears. However, the data that appears is not actually data from the production version, but persistent data from the earlier visit to the development version.

I think this is probably still confusing and therefore worth fixing so I won't close this, but the contributor may disagree. Perhaps something in the docs to highlight this bug would save others some debug time? 😀

@Akryum

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

Hi thanks for your bug report, but we no longer support Safari. Please use the standalone electron app instead.

@Akryum Akryum closed this Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.