Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: `store.replaceState` could be undefined at init hook #1127

Open
wants to merge 1 commit into
base: dev
from

Conversation

@JounQin JounQin force-pushed the JounQin:fix/replaceState branch from aa677eb to c681823 Dec 11, 2019
@JounQin

This comment has been minimized.

Copy link
Author

JounQin commented Dec 11, 2019

@Akryum Would you like to review this PR?

@JounQin

This comment has been minimized.

Copy link
Author

JounQin commented Dec 27, 2019

@posva @yyx990803 Can you take a look?...

@posva

This comment has been minimized.

Copy link
Member

posva commented Dec 27, 2019

Wait for @Akryum review, he will come when he can. Also, you should provide a repro of the bug or add a test that fails without the fix

@Akryum

This comment has been minimized.

Copy link
Member

Akryum commented Dec 27, 2019

A test could be nice 👍

@JounQin

This comment has been minimized.

Copy link
Author

JounQin commented Dec 27, 2019

you should provide a repro of the bug

I did provide an online reproduction and error capture in the issue description. It's clear how to fix it quickly but I don't have more time to figure out why it happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.