Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): support renaming for props #3656

Merged
merged 2 commits into from Jul 1, 2021
Merged

Conversation

@johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Apr 23, 2021

IDE features like find references / renaming... not working with RequiredKeys<O>, OptionalKeys<O> object keys types, this PR add [K in keyof O] to patch this problem.

Problems:

  • Not sure unknown type has consistency behavior with some special tsconfig.json settings.

Animation2

packages/runtime-core/src/componentProps.ts Outdated Show resolved Hide resolved
@johnsoncodehk johnsoncodehk changed the title feat: support renaming for props feat(runtime-core): support renaming for props Apr 23, 2021
pikax
pikax approved these changes Apr 23, 2021
@johnsoncodehk johnsoncodehk changed the title feat(runtime-core): support renaming for props feat(types): support renaming for props Apr 28, 2021
@yyx990803 yyx990803 merged commit 81e69b2 into vuejs:master Jul 1, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants