Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sfc): add defineEmits and deprecate defineEmit #3725

Merged
merged 1 commit into from Jun 22, 2021

Conversation

@posva
Copy link
Member

@posva posva commented May 5, 2021

Based on vuejs/rfcs#243 and the 3 other repeated PRs. I'm proposing to deprecate defineEmit in favour of defineEmits as defined in the RFC and to match the emits option as well as the plural of defineProps

Even though the we are defining the emit type of the context option in setup(props, { emit }), it seems more idiomatic to make it plural to match defineProps

@github-actions
Copy link

@github-actions github-actions bot commented May 5, 2021

Size report

Path Size
vue.global.prod.js 41.77 KB (+0.05% 🔺)
runtime-dom.global.prod.js 27.63 KB (+0.06% 🔺)
size-check.global.prod.js 16.8 KB (0%)

@yyx990803 yyx990803 force-pushed the master branch from 24f486f to fb96a85 May 8, 2021
@yyx990803 yyx990803 merged commit a137da8 into master Jun 22, 2021
2 of 3 checks passed
2 of 3 checks passed
@github-actions
size
Details
ci/circleci: test Your tests failed on CircleCI
Details
ci/circleci: test-dts Your tests passed on CircleCI!
Details
@yyx990803 yyx990803 deleted the refactor/defineEmits branch Jun 22, 2021
@yaiks yaiks mentioned this pull request Aug 10, 2021
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants