New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isError only identifies literal errors when extending Error and targeting IE #2509

Closed
michaeldjeffrey opened this Issue Nov 29, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@michaeldjeffrey

michaeldjeffrey commented Nov 29, 2018

Version

3.0.1

Reproduction link

https://codesandbox.io/s/o8v2plnoz

Steps to reproduce

Make a custom error using the class-extends syntax.
Throw error during a route transition.

What is expected?

Error is caught and sent to Router.onError handler.

What is actually happening?

Error is being identified as a plain object.


Have a custom error to carry notifications with uncaught errors in an application.
No notifications were showing up in production where we support IE11.
The custom error correctly identifies as an instanceof Error, but the util/isError function deems it an object.

I'm currently using some snippets from https://github.com/onury/custom-error-test to get the Error prototype on my custom error.

@posva

This comment has been minimized.

@posva posva closed this Nov 30, 2018

@michaeldjeffrey

This comment has been minimized.

michaeldjeffrey commented Nov 30, 2018

You are correct. I updated my babel packages and everything works fine now.
I must have been in that weird error vortex where I did the same thing on the babeljs website and it wasn't working for me. But today, lo and behold.

Thanks, and sorry @posva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment