Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility keyboard shortcuts #2637

Closed
joelworsham opened this Issue Mar 4, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@joelworsham
Copy link

joelworsham commented Mar 4, 2019

What problem does this feature solve?

When tabbing over router links, pressing the space or enter key does not trigger navigation. Although I can add this layer of logic myself, it seems that this should be natively supported.

What does the proposed API look like?

To the public, nothing would change, the links would just work on keyboard navigation.

@posva

This comment has been minimized.

Copy link
Member

posva commented Mar 4, 2019

This already works, if it doesn't provide a boiled down repro please

@posva posva closed this Mar 4, 2019

@joelworsham

This comment has been minimized.

Copy link
Author

joelworsham commented Mar 13, 2019

@posva You are right, and this issue may have been opened preemptively. However, we have identified the cause is that, somehow, the href is being stripped from the generated links, thus not becoming keyboard accessible. This could very well be a bug in our system, and we're looking into it, but it certainly is strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.