Join GitHub today
Console flooded with "Non-Error promise rejection captured with value: undefined" #3095
Steps to reproduce
What is expected?
Promise rejections contain error object or do not reject.
What is actually happening?
Console is flooded with "Non-Error promise rejection captured with value: undefined". We receive huge amount of Sentry issues automatically caught as
I assume, that the rejection should never happen.
To my very limited knowledge this line:
onAbort && onAbort(err)
should be replaced with this:
err && onAbort && onAbort(err)
This is related to the promise api when no callbacks are passed to push/replace. You can find about it in the docs and an explanation behind the change at #2881 (comment)
@Kolobok12309 you should be able to find the answer in that comment
@koresar in your case, it's a bit different because you are using a redirect, which internally is probably calling
The Promise API for navigation will go through an RFC for the next version of Vue Router, especially for what should and should not reject the promise
That was right guess, Eduardo. I do redirect and I do reject previous push.…
On Mon., 13 Jan. 2020, 22:43 Eduardo San Martin Morote, < ***@***.***> wrote: Closed #3095 <#3095>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3095?email_source=notifications&email_token=AAMMEL3BKCL3ZRS7RXUEMY3Q5RHX5A5CNFSM4KF2RP4KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV5UFX3I#event-2942852077>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMMEL52SXILZ7SPXSXRA3LQ5RHX5ANCNFSM4KF2RP4A> .