Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(zh): add more details to resolution flow #2710

Open
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
3 participants
@pot-code
Copy link

pot-code commented Apr 12, 2019

原文是“用创建好的实例调用 beforeRouteEnter 守卫中传给 next 的回调函数”,用创建好的什么实例?路由实例?

英文为“Call callbacks passed to next in beforeRouteEnter guards with instantiated instances”,我认为 call...with 应该是使用其作为调用 callback 参数的意思,而不是用它来调用 callback

@@ -153,4 +153,4 @@ beforeRouteLeave (to, from , next) {
9. 导航被确认。
10. 调用全局的 `afterEach` 钩子。
11. 触发 DOM 更新。
12. 用创建好的实例调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,被激活的组件实例会作为回调函数的参数传入

This comment has been minimized.

Copy link
@posva

posva Apr 12, 2019

Member
Suggested change
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,被激活的组件实例会作为回调函数的参数传入
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,被激活的组件实例会作为回调函数的参数传入

@posva posva changed the title docs: add more details to resolution flow docs(zh): add more details to resolution flow Apr 12, 2019

@posva

This comment has been minimized.

Copy link
Member

posva commented Apr 12, 2019

Where is this coming from? Is this also missing in English docs. Translation doesn't give me something readable 🙁 @Justineo

@posva posva added the docs label Apr 12, 2019

@@ -153,4 +153,4 @@ beforeRouteLeave (to, from , next) {
9. 导航被确认。
10. 调用全局的 `afterEach` 钩子。
11. 触发 DOM 更新。
12. 用创建好的实例调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,被激活的组件实例会作为回调函数的参数传入

This comment has been minimized.

Copy link
@Justineo

Justineo Apr 13, 2019

Member
Suggested change
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,被激活的组件实例会作为回调函数的参数传入
12. 调用 `beforeRouteEnter` 守卫中传给 `next` 的回调函数,创建好的组件实例会作为回调函数的参数传入。
@Justineo

This comment has been minimized.

Copy link
Member

Justineo commented Apr 13, 2019

@posva It's clarifying what “with instantiated instances” mean. Basically it's saying: the instantiated instances will serve as the argument of next's callback function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.