Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete redundant code #3010

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@iiijarvis
Copy link
Contributor

iiijarvis commented Oct 25, 2019

No need to judge again

searchIndex > -1
@posva
posva approved these changes Oct 25, 2019
Copy link
Member

posva left a comment

Thanks!

@@ -125,9 +125,7 @@ export function getHash (): string {
href = decodeURI(href.slice(0, hashIndex)) + href.slice(hashIndex)
} else href = decodeURI(href)
} else {
if (searchIndex > -1) {
href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex)

This comment has been minimized.

Copy link
@posva

posva Oct 25, 2019

Member
Suggested change
href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex)
href = decodeURI(href.slice(0, searchIndex)) + href.slice(searchIndex)
@posva posva merged commit 23dbc24 into vuejs:dev Oct 25, 2019
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: lint-flow-types Your tests failed on CircleCI
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-bs-ie9 Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@vue-bot

This comment has been minimized.

Copy link

vue-bot commented Oct 25, 2019

Hey @iiijarvis, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.