Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade path-to-regexp to v1.8.0 (resolves #2924) #3032

Open
wants to merge 3 commits into
base: dev
from

Conversation

@pimlie
Copy link

pimlie commented Nov 18, 2019

See issue #2925 and the commit messages.

The server host configuration commit could be omitted but I'm running Node on a remote docker cluster which means I need to set the host to 0.0.0.0. To be able to run the e2e tests I actually also needed to add 'no-sandbox', 'headless', 'disable-gpu', 'disable-dev-shm-usage' to chromeOptions.args in test/e2e/nightwatch.config.js. Otherwise Chrome wont be able to start in a docker container.

Copy link
Member

posva left a comment

Thanks! Could you move the test to a new one and also add a test that checks that case sensitive when the option is specified and that params do not match?

@pimlie

This comment has been minimized.

Copy link
Author

pimlie commented Nov 18, 2019

that checks that case sensitive when the option is specified

Hmm, I dont seem to have access to RouteConfig.caseSensitive in normalizeLocation as that only receives a Route type. Would it be ok to add the normalized pathToRegexpOptions to the RouteRecord type?

@posva

This comment has been minimized.

Copy link
Member

posva commented Nov 20, 2019

Ah right, it will need a test using the Router instance instance instead let's cover it that way for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.