Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-utils): add 'overview' function #1491

Merged
merged 6 commits into from Apr 8, 2020

Conversation

@SergiCL
Copy link
Contributor

@SergiCL SergiCL commented Mar 29, 2020

close #1461

What kind of change does this PR introduce? (check at least one)

  • Feature

Does this PR introduce a breaking change? (check one)

  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The main objective of this feature is "To give an overview of the state of the wrapper at the time the function is executed"

Example execution:

wraper.overview()

// Output
Wrapper (Visible):

Html:
    <div class="test">
      <p>My name is Tess Ting</p>
    </div>

Data: {
    firstName: Tess,
    lastName: Ting
}

Computed: {
    fullName: Tess Ting'
}

Emitted: {',
    foo: [',
        0: [ hello, world ],
        1: [ bye, world ]'
    ],
    bar: [
        0: [ hey ]'
    ]
}

More info

@lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Apr 1, 2020

Holy moly what a PR! I like how in depth your tests go.

Please give me some time to review this.

@SergiCL
Copy link
Contributor Author

@SergiCL SergiCL commented Apr 1, 2020

Holy moly what a PR! I like how in depth your tests go.

Please give me some time to review this.

Thank you. No problem, take as much time as you need.

@lmiller1990 lmiller1990 mentioned this pull request Apr 3, 2020
13 tasks
Copy link
Member

@lmiller1990 lmiller1990 left a comment

I left some comments!

test/specs/wrapper/overview.spec.js Outdated Show resolved Hide resolved
test/specs/wrapper/overview.spec.js Show resolved Hide resolved
test/specs/wrapper/overview.spec.js Show resolved Hide resolved
@SergiCL SergiCL requested a review from lmiller1990 Apr 7, 2020
Copy link
Member

@lmiller1990 lmiller1990 left a comment

looks like a solid PR.

this is the last API we will be adding before v1! This will go out with v1, should be in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants