Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 36b6e7e

Browse files
committed
Merge remote-tracking branch 'upstream/main'
2 parents cb3dfc6 + fe5d919 commit 36b6e7e

File tree

8 files changed

+16
-34
lines changed

8 files changed

+16
-34
lines changed

changelogs/CHANGELOG-3.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,7 @@ may cause build issues in projects still using TS 3.x.
773773
- **types:** adjust type exports for manual render function and tooling usage ([e4dc03a](https://github.com/vuejs/core/commit/e4dc03a8b17d5e9f167de6a62a645878ac7ef3e2)), closes [#1329](https://github.com/vuejs/core/issues/1329)
774774
- **types:** mixins/extends support in TypeScript ([#626](https://github.com/vuejs/core/issues/626)) ([d3c436a](https://github.com/vuejs/core/commit/d3c436ae2e66b75b7f2ed574dadda3f0e1fdce73))
775775
- **types:** support typing directive value via generic argument ([#1007](https://github.com/vuejs/core/issues/1007)) ([419b86d](https://github.com/vuejs/core/commit/419b86d1908f2a0521e6a7eafcbee764e9ee59a0)), closes [#998](https://github.com/vuejs/core/issues/998)
776-
- **types:** update to Typescript 3.9 ([#1106](https://github.com/vuejs/core/issues/1106)) ([97dedeb](https://github.com/vuejs/core/commit/97dedebd8097116a16209664a1ca38392b964da3))
776+
- **types:** update to TypeScript 3.9 ([#1106](https://github.com/vuejs/core/issues/1106)) ([97dedeb](https://github.com/vuejs/core/commit/97dedebd8097116a16209664a1ca38392b964da3))
777777

778778
### Performance Improvements
779779

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"@typescript-eslint/parser": "^6.18.1",
7777
"@vitest/coverage-istanbul": "^1.2.2",
7878
"@vitest/ui": "^1.2.2",
79-
"@vue/consolidate": "0.17.3",
79+
"@vue/consolidate": "1.0.0",
8080
"conventional-changelog-cli": "^4.1.0",
8181
"enquirer": "^2.4.1",
8282
"esbuild": "^0.20.0",

packages/compiler-core/__tests__/transforms/vOn.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ describe('compiler: transform v-on', () => {
271271
})
272272
})
273273

274-
test('should NOT wrap as function if expression is already function expression (with Typescript)', () => {
274+
test('should NOT wrap as function if expression is already function expression (with TypeScript)', () => {
275275
const { node } = parseWithVOn(`<div @click="(e: any): any => foo(e)"/>`)
276276
expect((node.codegenNode as VNodeCall).props).toMatchObject({
277277
properties: [

packages/dts-test/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# dts-test
22

3-
Tests Typescript types to ensure the types remain as expected.
3+
Tests TypeScript types to ensure the types remain as expected.
44

55
- This directory is included in the root `tsconfig.json`, where package imports are aliased to `src` directories, so in IDEs and the `pnpm check` script the types are validated against source code.
66

packages/sfc-playground/index.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
<link rel="icon" type="image/svg" href="/logo.svg" />
88
<title>Vue SFC Playground</title>
99
<script>
10-
// process shim for old versions of @vue/compiler-sfc dependency
11-
window.process = { env: {} }
1210
const savedPreferDark = localStorage.getItem('vue-sfc-playground-prefer-dark')
1311
if (
1412
savedPreferDark === 'true' ||

packages/sfc-playground/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"vite": "^5.0.12"
1414
},
1515
"dependencies": {
16-
"@vue/repl": "^4.0.0",
16+
"@vue/repl": "^4.1.0",
1717
"file-saver": "^2.0.5",
1818
"jszip": "^3.10.1",
1919
"vue": "workspace:*"

packages/sfc-playground/src/App.vue

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,9 @@ import {
1111
ImportMap,
1212
} from '@vue/repl'
1313
import type Monaco from '@vue/repl/monaco-editor'
14-
import type CodeMirror from '@vue/repl/codemirror-editor'
15-
import { ref, watchEffect, onMounted, computed, shallowRef, watch } from 'vue'
14+
import { ref, watchEffect, onMounted, computed, watch } from 'vue'
1615
import welcomeSFC from './welcome.vue?raw'
1716
18-
const EditorComponent = shallowRef<typeof Monaco | typeof CodeMirror>()
19-
20-
if (import.meta.env.DEV) {
21-
import('@vue/repl/codemirror-editor').then(
22-
mod => (EditorComponent.value = mod.default),
23-
)
24-
} else {
25-
import('@vue/repl/monaco-editor').then(
26-
mod => (EditorComponent.value = mod.default),
27-
)
28-
}
29-
3017
const replRef = ref<InstanceType<typeof Repl>>()
3118
3219
const setVH = () => {
@@ -186,6 +173,9 @@ function toggleTheme(isDark: boolean) {
186173
onMounted(() => {
187174
const cls = document.documentElement.classList
188175
toggleTheme(cls.contains('dark'))
176+
177+
// @ts-expect-error process shim for old versions of @vue/compiler-sfc dependency
178+
window.process = { env: {} }
189179
})
190180
</script>
191181

@@ -202,10 +192,9 @@ onMounted(() => {
202192
@reload-page="reloadPage"
203193
/>
204194
<Repl
205-
v-if="EditorComponent"
206195
ref="replRef"
207196
:theme="theme"
208-
:editor="EditorComponent"
197+
:editor="Monaco"
209198
@keydown.ctrl.s.prevent
210199
@keydown.meta.s.prevent
211200
:ssr="useSSRMode"

pnpm-lock.yaml

Lines changed: 6 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)