Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong definition of the type AsyncComponentFactory #10252

Open
Maorey opened this issue Jul 10, 2019 · 3 comments · May be fixed by #10253

Comments

@Maorey
Copy link

commented Jul 10, 2019

Version

2.6.10

Reproduction link

https://github.com/vuejs/vue

Steps to reproduce

  1. compare the AsyncComponentFactory definition with the document

What is expected?

attribute 'component' should be a promise

What is actually happening?

AsyncComponentPromise


I'm looking forward to your solution to this issue

@posva

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

It seems the type should be Promise<Component | EsModuleComponent>

@NataliaTepluhina NataliaTepluhina referenced a pull request that will close this issue Jul 10, 2019
6 of 13 tasks complete
@posva posva added the has PR label Jul 10, 2019
NataliaTepluhina added a commit to NataliaTepluhina/vue that referenced this issue Jul 14, 2019
NataliaTepluhina added a commit to NataliaTepluhina/vue that referenced this issue Jul 14, 2019
@Maorey Maorey closed this Jul 22, 2019
@posva posva reopened this Jul 22, 2019
@harshajayaweeraXHJ

This comment has been minimized.

Copy link

commented Aug 31, 2019

Is this issue still available

@jvik

This comment has been minimized.

Copy link

commented Oct 2, 2019

@harshajayaweeraXHJ The issue already has a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.