Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue DevTools recommendation only shows for Chrome, not Firefox #8634

Closed
digitarald opened this issue Aug 10, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@digitarald
Copy link

commented Aug 10, 2018

Version

2.5.17

Reproduction link

http://localhost:8080 (any local dev setup)

Steps to reproduce

  • Run any dev build
  • Open the page Firefox without vue devtools installed
  • Open devtools console

What is expected?

Devtools extension gets recommended

What is actually happening?

Recommendation only shows for Chrome, not in Firefox


Logic is in https://github.com/vuejs/vue/blob/master/src/platforms/web/runtime/index.js#L51

Twist is that isChrome is only used in this one code; so maybe it could be changed to hasCompatibleExtension and include a Firefox UA detection. Alternatively UA detection can be dropped, so the link is always shown and users can figure out that they might switch browsers to use the devtools.

@posva

This comment has been minimized.

Copy link
Member

commented Aug 11, 2018

I know we can show it for Firefox and Safari as well. @znck @Akryum is it possible to always display it once we have the remote devtools or does something else need to be changed?

@kotAPI

This comment has been minimized.

Copy link

commented Oct 13, 2018

Can I take this up? :)

@posva posva added the has PR label Oct 17, 2018

yyx990803 added a commit that referenced this issue Dec 20, 2018

@yyx990803

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

Closed via #8638

@yyx990803 yyx990803 closed this Dec 20, 2018

f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.