Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keydown Events not Working in IE11 for Space bar, Escape and Delete #9112

Closed
nitramL opened this issue Nov 26, 2018 · 5 comments
Closed

Keydown Events not Working in IE11 for Space bar, Escape and Delete #9112

nitramL opened this issue Nov 26, 2018 · 5 comments
Labels

Comments

@nitramL
Copy link

@nitramL nitramL commented Nov 26, 2018

Version

2.5.17

Reproduction link

https://jsfiddle.net/cwnv6djs/

Steps to reproduce

Click on the input field
Press the space bar or Escape or Delete

What is expected?

The label under the input should display "space" or "escape" or "delete"

What is actually happening?

Nothing


Seems like KeyboardEvent.key in IE11 are :

  • "Spacebar" for space bar
  • "Esc" for Escape
  • "Del" for Delete
@posva
Copy link
Member

@posva posva commented Nov 26, 2018

Escape was already fixed but maybe others need to be added here
1bd6196. I haven't checked the repro yet though

@nitramL
Copy link
Author

@nitramL nitramL commented Nov 27, 2018

@posva you're right, Escape was fixed in 2.5.17-beta.0 (https://github.com/vuejs/vue/blob/v2.5.17-beta.0/src/compiler/codegen/events.js) but isn't in 2.5.17 (https://github.com/vuejs/vue/blob/v2.5.17/src/compiler/codegen/events.js)...

Wasn't 2.5.17-beta.0 released before 2.5.17 ?
If so, shouldn't this change be merged in 2.5.17 ?

@posva
Copy link
Member

@posva posva commented Nov 27, 2018

this will be released in next version, that last patch was a security release

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Dec 4, 2018

Wasn't 2.5.17-beta.0 released before 2.5.17 ?
If so, shouldn't this change be merged in 2.5.17 ?

2.5.17 is 2.5.16 + a critical security bugfix which came up after 2.5.17-beta.0 was released, so it doesn'T contain anything that's in 2.5.17-beta.0

2.5.17-beta.0 hasn't made it into an official release yet, and we now have 2.5.18-beta.0 out including these and other fixes.

@nitramL
Copy link
Author

@nitramL nitramL commented Dec 4, 2018

Crystal clear!
Thanks for the explanation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants