Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a spelling mistake #10358

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@git-nkliyc
Copy link
Contributor

commented Aug 7, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: spelling mistake

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

git-nkliyc added 2 commits Aug 7, 2019
Update error-detector.js
There is a spelling mistakes in the function checkEvent
Update error-detector.js
update a spelling mistake in the function checkEvent.
@posva
posva approved these changes Aug 7, 2019
Copy link
Member

left a comment

Thanks!

@posva posva merged commit d40b7dd into vuejs:dev Aug 7, 2019

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Hey @git-nkliyc, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@git-nkliyc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.