Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastcoding Inc broken icon #10638

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@Naartti
Copy link
Contributor

Naartti commented Oct 14, 2019

I've recently send a PR to vuejs.org with a .png version of the Fastcoding Inc logo. When/if it's merged, change this .svg link to .png.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
It's just one logo-link in the README that's a svg, all other are png.

I've recently send a PR to vuejs.org with a .png version of the Fastcoding Inc logo. When/if it's merged, change this .svg link to .png.
@Naartti

This comment has been minimized.

Copy link
Contributor Author

Naartti commented Oct 14, 2019

UPDATE: The PR is now merged to master for vuejs.org and fastcoding_inc.png is available via the updated link.

@posva

This comment has been minimized.

Copy link
Member

posva commented Oct 14, 2019

ping @yyx990803

@yyx990803 yyx990803 merged commit d1164f1 into vuejs:dev Oct 28, 2019
5 checks passed
5 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
@vue-bot

This comment has been minimized.

Copy link
Contributor

vue-bot commented Oct 28, 2019

Hey @Naartti, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.