Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add rollup-plugin-json-parse #10879

Open
wants to merge 1 commit into
base: dev
from

Conversation

@tjenkinson
Copy link

tjenkinson commented Nov 30, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This adds rollup-plugin-json-parse, which is configured to convert large objects to strings that are JSON.parse'd. This should actually increase performance

It currently modifies '/packages/vue-server-renderer/basic.js' and '/packages/vue-template-compiler/browser.js'. Click here to see the diff

Would be interesting if to see if it actually makes a difference here, if you have any benchmarks that could be run?

@tjenkinson tjenkinson marked this pull request as ready for review Dec 1, 2019
@tjenkinson tjenkinson force-pushed the tjenkinson:rollup-plugin-parse branch from fe5aaad to 3caa584 Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.