fix v-bind.prop parse (fix #4432) #4435

Merged
merged 4 commits into from Dec 11, 2016

Projects

None yet

3 participants

@defcc
Member
defcc commented Dec 10, 2016

fix #4432

+ template: '<input :some.prop="some" :id="id">',
+ data: {
+ some: 'hello',
+ id: 'world'
@posva
posva Dec 10, 2016 Member

Actually, the test case should use a null or false value and check that the id attribute is absent on the element

@defcc
defcc Dec 10, 2016 edited Member

Thanks, I updated the test case

@posva
Member
posva commented Dec 10, 2016

I can't believe the fix was that easy 😆
Good job again @defcc 👍

@posva
posva approved these changes Dec 10, 2016 View changes

I'd like to see the tests pass on CI, though 😆

@defcc
Member
defcc commented Dec 10, 2016

For the test case, the id attribute is special, it reflects both with attribute and property.

@yyx990803 yyx990803 merged commit 183bd43 into vuejs:dev Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment