Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove src directory from npm module #6072

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

KELiON
Copy link
Contributor

@KELiON KELiON commented Jul 11, 2017

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Breaking change is only for users, who uses undocumented requires/imports from vue/src. After this PR all scripts from src folder are not included in npm-package

The PR fulfills these requirements:

Other information:

src directory is not used by node package. Removing this directory reduces size of .tgz package by 112kb and saves 840kb in each node project, where vue.js is installed

`src` directory is not used by node package. Removing this directory reduces size of `.tgz` package by 112kb and saves 840kb on each node projects, where vue.js is installed
@andreiglingeanu
Copy link

Agreed, almost everyone who want to build Vue themselves are using vue/dist/vue.esm.js outputs

@rigor789
Copy link

Hi, this change is a good performance improvement, however it is a breaking change for https://github.com/rigor789/nativescript-vue

Due to the nature of nativescript-vue we have to use some code from the src directory.

I am here to ask if there is a better approach to our problem, than importing directly from src?

As for this change, I have tried installing directly through GitHub, using either a tag, or a commit hash, but in all cases I got the version without the src directory. Do you have any suggestions how to move forward with this change?

@yyx990803
Copy link
Member

Ah, yeah I realized that problem. Will revert it in a later release.

yyx990803 added a commit that referenced this pull request Jul 21, 2017
adding src dir back to npm package because projects that create
custom renderers (e.g. nativescript-vue) relie on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants