Support boolean attributes#91
Merged
Merged
Conversation
Member
|
Hi Yuriy, I have tested locally and it's looking good. Just one final thing: please do not include the |
Author
|
@yyx990803 Fixed! =) |
Member
|
Merged! Thanks for the great work! 👍 |
|
🍻 I just ran into this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
v-attrimplementation doesn't support boolean attributes (e.g.disabled).Here is the common use-case:
It doesn't work because
v-attrusesthis.el.setAttributemethod. So, whensubmittionAllowedequals totrue, then submit button will look like this:...which is treated by browser as disabled button.
My proposal is to remove current attribute if it's value is falsy (except zero).