New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): renderToString cannot render comment #9128

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@clarkdo
Contributor

clarkdo commented Nov 30, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix nuxt/nuxt.js#4458

@posva

This comment has been minimized.

Member

posva commented Nov 30, 2018

Don't forget the test case 😄

@clarkdo

This comment has been minimized.

Contributor

clarkdo commented Nov 30, 2018

@posva renderToString is using normalizeRender to create the compiler, but it doesn't pass comments parameter, so comments won't be renderered even after my pr.

But this pr can fix the scenario that component is loaded from vue-loader which is using comments attr to set the comments parameter.

@yyx990803

This comment has been minimized.

Member

yyx990803 commented Dec 1, 2018

We could have a test case that manually compiles the template with explicit comments options. A bit tedious but I think a test case is still needed.

@clarkdo

This comment has been minimized.

Contributor

clarkdo commented Dec 1, 2018

Make sense, I’ll add one.

@clarkdo clarkdo force-pushed the clarkdo:ssr-comments branch from f1d32cb to 922a111 Dec 12, 2018

@clarkdo

This comment has been minimized.

Contributor

clarkdo commented Dec 12, 2018

@yyx990803 @posva Test added.

@yyx990803 yyx990803 merged commit b06c784 into vuejs:dev Dec 12, 2018

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment