New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): style binding keeps falsy values (#9231) #9290

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
3 participants
@bny6613
Copy link

bny6613 commented Jan 8, 2019

What kind of change does this PR introduce? (check at least one)

  • [ x] Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [x ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@manniL

manniL approved these changes Jan 8, 2019

@yyx990803

This comment has been minimized.

Copy link
Member

yyx990803 commented Jan 11, 2019

Thanks for the PR! As I was reviewing it, I noticed that falsy values are just a part of the problem, so there is a more complete fix in 7d9cfeb.

@yyx990803 yyx990803 closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment