New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add optional store field into ComponentOptions types #9302

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@mickaelw
Copy link

mickaelw commented Jan 10, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Add store field into types for TypeScript

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva

This comment has been minimized.

Copy link
Member

posva commented Jan 10, 2019

Thanks but this is added by vuex: https://github.com/vuejs/vuex/blob/dev/types/vue.d.ts

@posva posva closed this Jan 10, 2019

@mickaelw

This comment has been minimized.

Copy link

mickaelw commented Jan 10, 2019

@posva maybe but when we want to use Redux with Vue and TypeScript. This missing raise up a TypeScript compile error

@posva

This comment has been minimized.

Copy link
Member

posva commented Jan 10, 2019

it's up to the plugin to add the typing the same way vuex did 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment