New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle hooks, expose "this" typing to all of them #9303

Open
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
1 participant
@christianalfoni
Copy link

christianalfoni commented Jan 10, 2019

What kind of change does this PR introduce? (check at least one)

  • [ X ] Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ X ] No

The PR fulfills these requirements:

Other information:
I am not sure why only beforeCreate has the "this" typing? Working on something that would benefit from all of the lifecycle hooks having the "this" typing, which is technically correct as well.

Did not see any actual type testing for this? So did not implement that.

lifecycle hooks, this
I am not sure why only `beforeCreate` has the "this" typing? Working on something that would benefit from all of the lifecycle hooks having the "this" typing, which is technically correct as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment