New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types) add exported version to type definiton #9431

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@mathe42
Copy link
Contributor

mathe42 commented Feb 6, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

import Vue from 'vue';

console.log(Vue.version)

currently throws an Error with: Property 'version' does not exist on type 'VueConstructor<Vue>'.

My PR fixed that...

@yyx990803 yyx990803 merged commit 54e6a12 into vuejs:dev Feb 6, 2019

4 of 5 checks passed

ci/circleci: test-ssr-weex Your tests failed on CircleCI
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment