Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not push non-async css files into map #9677

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@clarkdo
Copy link
Contributor

clarkdo commented Mar 11, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fix nuxt/nuxt.js#5190

Since #7902 has already implemented initial and async for css, so make fileMapper only include async css files same as js files for avoiding duplicate style tags.

@yyx990803

This comment has been minimized.

Copy link
Member

yyx990803 commented Mar 12, 2019

Can you provide some more context for this fix?

@clarkdo

This comment has been minimized.

Copy link
Contributor Author

clarkdo commented Mar 12, 2019

@yyx990803 It happened in extracting css.
When I extracted css from entrypoint, the css file will be in initial in manifest , then during, renderring, it will also be put into async which is used in renderStyles since all initial files except js are all put into async.

@AlexDubok

This comment has been minimized.

Copy link

AlexDubok commented Mar 13, 2019

Hi! Found this pr because I have the same issue. Initial css files are being put into async files array, wich is then combined here with initial files array and used to render style links.

@yyx990803 yyx990803 merged commit d282400 into vuejs:dev Mar 13, 2019

5 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details

@clarkdo clarkdo deleted the clarkdo:async-css branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.